We get wrong line count from the CMergeEditView::OnVScroll method. > LocationView::DrawVisibleAreaRect() it means we have wrong linecounts in Maybe I someday have time for refactoring this locationpane code. I know whole visible area was a hacky solution, and it was me implementing it. Sorry, I just think we shouldn't apply this kind of workarounds, they only hide the bug and make real bugs harder to find.
We should be getting correct linenumbers, what is the point of those linenumbers as parameters if they aren't correct? And this patch also would cause us to do unnecessary callback to MergeEditView which isn't good.
And I'm afraid that actual bug (MergeEditView having wrong linenumbers) isn't easy.
It just makes us work correctly in one case, but leaves actual bug untouched. NTopLine = pDoc->GetRightView\(\)->GetTopLine\(\) Īnd as CMergeEditView::UpdateLocationViewPosition() function calls LocationView::DrawVisibleAreaRect() it means we have wrong linecounts in MergeEditView.
0 kommentar(er)
